Franciskid
f1989f8824
JellyfinGuestUserService looked up IUserManager methods by reflection, trying eight candidate signatures for ChangePassword alone, and ItemTagService did the same for UpdateItemAsync. That fails at runtime on any API drift and only logs a warning, which is exactly how the DbUpdateConcurrencyException hunt started. We already pin Jellyfin.Controller 10.11, so these are now plain typed calls and any future drift is a compile error. 427 lines of shim gone, behaviour unchanged (UpdateItemAsync still gets ItemUpdateType.None, password still set before the policy update). Guest accounts also get their own authentication provider now, which refuses every interactive sign-in. Redemption is unaffected: AuthenticateDirect passes enforcePassword false and never consults a provider. If the plugin is disabled the provider id stops resolving and Jellyfin assigns the account to its own InvalidAuthProvider, which refuses too, so this fails closed. A random password is still set as a second line of defence.
36 lignes
1.5 KiB
C#
36 lignes
1.5 KiB
C#
using Jellyfin.Plugin.ShareLinks.Lifecycle;
|
|
using Jellyfin.Plugin.ShareLinks.Services;
|
|
using Jellyfin.Plugin.ShareLinks.Storage;
|
|
using Jellyfin.Plugin.ShareLinks.Web;
|
|
using MediaBrowser.Controller;
|
|
using MediaBrowser.Controller.Authentication;
|
|
using MediaBrowser.Controller.Plugins;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
|
|
namespace Jellyfin.Plugin.ShareLinks;
|
|
|
|
/// <summary>
|
|
/// Registers the foundational ShareLinks services used by later API and web
|
|
/// workers.
|
|
/// </summary>
|
|
public class PluginServiceRegistrator : IPluginServiceRegistrator
|
|
{
|
|
/// <inheritdoc />
|
|
public void RegisterServices(IServiceCollection serviceCollection, IServerApplicationHost applicationHost)
|
|
{
|
|
_ = applicationHost;
|
|
|
|
serviceCollection.AddHostedService<WebInjectionHostedService>();
|
|
serviceCollection.AddSingleton<ShareLinkStore>();
|
|
serviceCollection.AddSingleton<ShareTokenService>();
|
|
serviceCollection.AddSingleton<ItemTagService>();
|
|
serviceCollection.AddSingleton<JellyfinGuestUserService>();
|
|
serviceCollection.AddSingleton<IAuthenticationProvider, GuestAuthenticationProvider>();
|
|
serviceCollection.AddSingleton<ShareLinkCreationService>();
|
|
serviceCollection.AddSingleton<ShareLinkRedemptionService>();
|
|
serviceCollection.AddSingleton<ShareLinkCleanupService>();
|
|
serviceCollection.AddSingleton<IShareLinkCleanupService>(provider => provider.GetRequiredService<ShareLinkCleanupService>());
|
|
serviceCollection.AddHostedService<StartupCleanupHostedService>();
|
|
}
|
|
}
|