public/jellyfin-plugin-sharelinks
1
0
Bifurcation 0
Code Tickets Demandes d'ajout Actions Paquets Projets Publications 1 Wiki Activité

ShareLinks: make guest redemption actually work end to end

Parcourir la source 
The sign-in bootstrap sent the auth request body as a JS object, so it
was coerced to [object Object] and AuthenticateByName returned 400. Send
JSON.stringify(...) instead.

Guest credentials were written to localStorage as a flat object under
made-up keys. jellyfin-web reads jellyfin_credentials as
{Servers:[{Id,AccessToken,UserId,...}]}, so the guest was treated as
logged out. Write that shape, pulling server Id/name from
System/Info/Public, and redirect with the 10.11 hash route
(#/details?id=...&serverId=...) instead of the legacy #!/ form that
rendered a blank page.

Creating a link now rejects folders and libraries (only movies and
episodes are shareable) so a guest cannot land on an empty tag-filtered
library. Item ids from the menu action are validated as GUIDs client
side, rejected creates are logged server side, malformed redeem tokens
return 404 instead of 500, and the admin table shows the item name and a
copyable link instead of the raw item id.
Cette révision appartient à :
Franciskid
2026-07-06 23:37:08 +02:00
Parent c29ea7f20c
révision c964b4e37a
6 fichiers modifiés avec 165 ajouts et 41 suppressions
Télécharger le Fichier Patch Télécharger le Fichier des Différences Développer tous les fichiers Réduire tous les fichiers
Jellyfin.Plugin.ShareLinks/Services/ShareLinkRedemptionService.cs
+32 -14
Voir le fichier
@@ -45,6 +45,11 @@ public sealed class ShareLinkRedemptionService
public async Task<string?> RedeemAsync(string rawToken, HttpRequest request, CancellationToken cancellationToken)
{
var tokenHash = await _tokenService.HashTokenAsync(rawToken, cancellationToken).ConfigureAwait(false);
if (tokenHash is null)
{
return null;
}
var record = await _store.GetByTokenHashAsync(tokenHash, cancellationToken).ConfigureAwait(false);
if (record is null)
{
@@ -179,7 +184,7 @@ public sealed class ShareLinkRedemptionService
{
var pathBase = request.PathBase.Value ?? string.Empty;
var authUrl = $"{pathBase}/Users/AuthenticateByName";
var redirectUrl = $"{pathBase}/web/index.html#!/details?id={Uri.EscapeDataString(itemId.ToString("D"))}";
var redirectUrl = $"{pathBase}/web/index.html#/details?id={Uri.EscapeDataString(itemId.ToString("D"))}";
var username = record.GuestUserName ?? JellyfinGuestUserService.BuildGuestUsername(record);
var deviceId = record.DeviceId ?? string.Empty;
@@ -193,6 +198,8 @@ public sealed class ShareLinkRedemptionService
var redirectUrlJson = JsonSerializer.Serialize(redirectUrl);
var usernameJson = JsonSerializer.Serialize(username);
var deviceIdJson = JsonSerializer.Serialize(deviceId);
var infoUrlJson = JsonSerializer.Serialize($"{pathBase}/System/Info/Public");
var pathBaseJson = JsonSerializer.Serialize(pathBase);
return $$"""
<!doctype html>
@@ -229,7 +236,7 @@ public sealed class ShareLinkRedemptionService
"Accept": "application/json",
"X-Emby-Authorization": `MediaBrowser Client="ShareLinks", Device="ShareLinks", DeviceId="${deviceId}", Version="1.0.0"`
},
body: {{authJson}}
body: JSON.stringify({{authJson}})
});
if (!response.ok) {
@@ -239,24 +246,35 @@ public sealed class ShareLinkRedemptionService
const auth = await response.json();
const accessToken = auth.AccessToken ?? auth.accessToken ?? "";
const userId = auth.User?.Id ?? auth.user?.Id ?? auth.UserId ?? auth.userId ?? "";
const userName = auth.User?.Name ?? auth.user?.Name ?? auth.UserName ?? auth.userName ?? username;
const snapshot = {
AccessToken: accessToken,
UserId: userId,
UserName: userName,
ServerUrl: window.location.origin
const info = await fetch({{infoUrlJson}}, {
credentials: "same-origin",
headers: { "Accept": "application/json" }
}).then((r) => r.json());
const serverAddress = window.location.origin + {{pathBaseJson}};
const credentials = {
Servers: [
{
ManualAddress: serverAddress,
manualAddressOnly: true,
Name: info.ServerName || "Jellyfin",
Id: info.Id,
LastConnectionMode: 1,
AccessToken: accessToken,
UserId: userId,
DateLastAccessed: Date.now()
}
]
};
try {
for (const key of ["jellyfinCredentials", "jellyfin_credentials", "jellyfin-credentials"]) {
localStorage.setItem(key, JSON.stringify(snapshot));
}
localStorage.setItem("jellyfin.server", window.location.origin);
localStorage.setItem("jellyfin_credentials", JSON.stringify(credentials));
} catch (_) {
// Best effort only. Jellyfin Web storage format should be verified live.
// If storage is blocked the redirect lands on the login screen.
}
window.location.replace(redirectUrl);
window.location.replace(redirectUrl + "&serverId=" + encodeURIComponent(info.Id));
})().catch((error) => {
console.error(error);
document.getElementById("status").textContent = "Sign-in failed.";