harden redemption, expiry limits and token storage
Findings from a pass over the plugin, smallest first: Redemptions now run one at a time behind a gate. The status checks and the status write that follows them were not atomic, so two requests arriving together with the same one-use token could both mint a guest session. The spent-link check also moved above the tagging step, so hammering an already-used link no longer re-tags a whole series on every hit. The configured maximum expiry is actually respected. Both the API and the picker did Math.max(configured, 720), so setting the ceiling to anything under 30 days was silently ignored. The picker now also hides the quick-pick durations that sit above the ceiling. The share URL, which carries the raw token, is dropped from the record when the link is revoked or expires. Records are never deleted, so dead tokens were accumulating in the store forever. Live links keep it so the dashboard can still copy them, and the README claim that no token is ever written to disk is corrected to say what the code actually does. The HMAC key file is created 0600 instead of inheriting the default mask.
Cette révision appartient à :
@@ -892,14 +892,15 @@
|
||||
}
|
||||
|
||||
function chooseExpiryHours(config, onChoose) {
|
||||
var options = durationOptions.map(function (option) {
|
||||
var maxHours = clampPositiveInteger(config && config.MaxExpiryHours, 720);
|
||||
var options = durationOptions.filter(function (option) {
|
||||
return option.hours <= maxHours;
|
||||
}).map(function (option) {
|
||||
return {
|
||||
label: durationLabel(option.hours),
|
||||
hours: option.hours
|
||||
};
|
||||
});
|
||||
|
||||
var maxHours = Math.max(clampPositiveInteger(config && config.MaxExpiryHours, 720), 720);
|
||||
var nowMs = Date.now();
|
||||
var minDate = new Date(nowMs + 5 * 60000);
|
||||
var maxDate = new Date(nowMs + maxHours * 3600000);
|
||||
|
||||
Référencer dans un nouveau ticket
Bloquer un utilisateur